Skip to content

Commit

Permalink
test: remove common.localhostIPv6
Browse files Browse the repository at this point in the history
common.localhostIPv6 is almost entirely unused and is unnecessary.
Remove it.

PR-URL: #34373
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
Trott authored and MylesBorins committed Jul 27, 2020
1 parent 668632d commit 699da05
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 0 additions & 2 deletions test/common/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -773,8 +773,6 @@ const common = {
return localhostIPv4;
},

get localhostIPv6() { return '::1'; },

// opensslCli defined lazily to reduce overhead of spawnSync
get opensslCli() {
if (opensslCli !== null) return opensslCli;
Expand Down
4 changes: 2 additions & 2 deletions test/sequential/test-net-connect-local-error.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ const optionsIPv4 = {
};

const optionsIPv6 = {
host: common.localhostIPv6,
host: '::1',
port: common.PORT + 2,
localPort: common.PORT + 3,
localAddress: common.localhostIPv6
localAddress: '::1',
};

function onError(err, options) {
Expand Down

0 comments on commit 699da05

Please sign in to comment.