Skip to content

Commit

Permalink
http2: core.js replace var with let
Browse files Browse the repository at this point in the history
const has to be used in for in loop

PR-URL: #30403
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
  • Loading branch information
DanielSchuech authored and MylesBorins committed Dec 17, 2019
1 parent 1a83c65 commit 68f3dde
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/internal/http2/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ function onOrigin(origins) {
if (!session.encrypted || session.destroyed)
return undefined;
const originSet = initOriginSet(session);
for (var n = 0; n < origins.length; n++)
for (let n = 0; n < origins.length; n++)
originSet.add(origins[n]);
session.emit('origin', origins);
}
Expand Down Expand Up @@ -1518,7 +1518,7 @@ class ServerHttp2Session extends Http2Session {
let arr = '';
let len = 0;
const count = origins.length;
for (var i = 0; i < count; i++) {
for (let i = 0; i < count; i++) {
let origin = origins[i];
if (typeof origin === 'string') {
origin = (new URL(origin)).origin;
Expand Down Expand Up @@ -2150,7 +2150,7 @@ function processHeaders(oldHeaders) {
if (oldHeaders !== null && oldHeaders !== undefined) {
const hop = hasOwnProperty.bind(oldHeaders);
// This loop is here for performance reason. Do not change.
for (var key in oldHeaders) {
for (const key in oldHeaders) {
if (hop(key)) {
headers[key] = oldHeaders[key];
}
Expand Down

0 comments on commit 68f3dde

Please sign in to comment.