Skip to content

Commit

Permalink
test: replace common.PORT with 0 in https renegotiation test
Browse files Browse the repository at this point in the history
Repeated use of common.PORT was resulting in sporadic failures on some
operating systems.

PR-URL: #25599
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
  • Loading branch information
Trott authored and addaleax committed Jan 23, 2019
1 parent d9a8113 commit 6881454
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/pummel/test-https-ci-reneg-attack.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ function test(next) {
res.end('ok');
});

server.listen(common.PORT, function() {
const args = (`s_client -connect 127.0.0.1:${common.PORT}`).split(' ');
server.listen(0, function() {
const cmd = `s_client -connect 127.0.0.1:${server.address().port}`;
const args = cmd.split(' ');
const child = spawn(common.opensslCli, args);

child.stdout.resume();
Expand Down

0 comments on commit 6881454

Please sign in to comment.