tools: synchronize deepStrictEqual() message rules

Update ESLint config to include a rule about assert.deepStrictEqual() messages and string literals. The rule is included in lib and test, but should be included everywhere else as well. PR-URL: #22887 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Richard Lau <[email protected]>
nodejs · Sep 20, 2018 · 6367349 · 6367349
1 parent 25220f0
commit 6367349
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -159,6 +159,10 @@ module.exports = {
     // and test/.eslintrc.yaml.
     'no-restricted-syntax': [
       'error',
+      {
+        selector: "CallExpression[callee.object.name='assert'][callee.property.name='deepStrictEqual'][arguments.2.type='Literal']",
+        message: 'Do not use a literal for the third argument of assert.deepStrictEqual()'
+      },
       {
         selector: "CallExpression[callee.object.name='assert'][callee.property.name='doesNotThrow']",
         message: 'Please replace `assert.doesNotThrow()` and add a comment next to the code instead.'