assert: revert breaking change

It was not intended to change the `assert.doesNotThrow()` message with #23223. This reverts the breaking behavior to the one before. PR-URL: #24786 Refs: #23223 Reviewed-By: Beth Griggs <[email protected]>
nodejs · Dec 11, 2018 · 62fb5db · 62fb5db
1 parent 74c1074
commit 62fb5db
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/assert.js b/lib/assert.js
@@ -782,7 +782,7 @@ function expectsNoError(stackStartFn, actual, error, message) {
       actual,
       expected: error,
       operator: stackStartFn.name,
-      message: `Got unwanted ${fnType}${details}\n${actual.message}`,
+      message: `Got unwanted ${fnType}${details}`,
       stackStartFn
     });
   }

diff --git a/test/parallel/test-assert-async.js b/test/parallel/test-assert-async.js
@@ -34,7 +34,7 @@ common.crashOnUnhandledRejection();
         assert(err instanceof assert.AssertionError,
                `${err.name} is not instance of AssertionError`);
         assert.strictEqual(err.code, 'ERR_ASSERTION');
-        assert(/^Got unwanted rejection\.\n$/.test(err.message));
+        assert(/^Got unwanted rejection\.$/.test(err.message));
         assert.strictEqual(err.operator, 'doesNotReject');
         assert.ok(!err.stack.includes('at Function.doesNotReject'));
         return true;

diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
@@ -460,7 +460,7 @@ common.expectsError(
     type: a.AssertionError,
     code: 'ERR_ASSERTION',
     operator: 'doesNotThrow',
-    message: 'Got unwanted exception: user message\n[object Object]'
+    message: 'Got unwanted exception: user message'
   }
 );