test: update test-http-response-multiheaders to use countdown

PR-URL: #17419 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]>
nodejs · Dec 12, 2017 · 5fecdba · 5fecdba
1 parent 69e775d
commit 5fecdba
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/test/parallel/test-http-response-multiheaders.js b/test/parallel/test-http-response-multiheaders.js
@@ -3,6 +3,7 @@
 const common = require('../common');
 const http = require('http');
 const assert = require('assert');
+const Countdown = require('../common/countdown');
 
 // Test that certain response header fields do not repeat.
 // 'content-length' should also be in this list but it is
@@ -27,6 +28,7 @@ const norepeat = [
   'age',
   'expires'
 ];
+const runCount = 2;
 
 const server = http.createServer(function(req, res) {
   const num = req.headers['x-num'];
@@ -47,8 +49,8 @@ const server = http.createServer(function(req, res) {
 });
 
 server.listen(0, common.mustCall(function() {
-  let count = 0;
-  for (let n = 1; n <= 2; n++) {
+  const countdown = new Countdown(runCount, () => server.close());
+  for (let n = 1; n <= runCount; n++) {
     // this runs twice, the first time, the server will use
     // setHeader, the second time it uses writeHead. The
     // result on the client side should be the same in
@@ -58,7 +60,7 @@ server.listen(0, common.mustCall(function() {
     http.get(
       { port: this.address().port, headers: { 'x-num': n } },
       common.mustCall(function(res) {
-        if (++count === 2) server.close();
+        countdown.dec();
         for (const name of norepeat) {
           assert.strictEqual(res.headers[name], 'A');
         }