test: deflake test-diagnostics-channel-net

This test uses the deprecated methods in `diagnostic_channel` (see the
reference), which are deprecated because the channels can be GC'd while
in use, leading to lost messages.

Change to use the non-deprecated APIs, which should work. I wasn't able
to reproduce this locally; I assume it's memory dependent.

Refs: #42714
Fixes: #44143
PR-URL: #44144
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

test/parallel/test-diagnostics-channel-net.js

@@ -4,16 +4,13 @@ const assert = require('assert');
 const net = require('net');
 const dc = require('diagnostics_channel');
 
-const netClientSocketChannel = dc.channel('net.client.socket');
-const netServerSocketChannel = dc.channel('net.server.socket');
-
 const isNetSocket = (socket) => socket instanceof net.Socket;
 
-netClientSocketChannel.subscribe(common.mustCall(({ socket }) => {
+dc.subscribe('net.client.socket', common.mustCall(({ socket }) => {
   assert.strictEqual(isNetSocket(socket), true);
 }));
 
-netServerSocketChannel.subscribe(common.mustCall(({ socket }) => {
+dc.subscribe('net.server.socket', common.mustCall(({ socket }) => {
   assert.strictEqual(isNetSocket(socket), true);
 }));