stream: use for...of

PR-URL: #30960 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Dec 17, 2019 · 5ca29d8 · 5ca29d8
1 parent d8ce9a0
commit 5ca29d8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/lib/_stream_duplex.js b/lib/_stream_duplex.js
@@ -42,9 +42,7 @@ ObjectSetPrototypeOf(Duplex, Readable);
 
 {
   // Allow the keys array to be GC'ed.
-  const keys = ObjectKeys(Writable.prototype);
-  for (let v = 0; v < keys.length; v++) {
-    const method = keys[v];
+  for (const method of ObjectKeys(Writable.prototype)) {
     if (!Duplex.prototype[method])
       Duplex.prototype[method] = Writable.prototype[method];
   }

diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -874,8 +874,8 @@ Readable.prototype.unpipe = function(dest) {
     state.pipes = [];
     state.flowing = false;
 
-    for (var i = 0; i < dests.length; i++)
-      dests[i].emit('unpipe', this, { hasUnpiped: false });
+    for (const dest of dests)
+      dest.emit('unpipe', this, { hasUnpiped: false });
     return this;
   }
 
@@ -1079,8 +1079,8 @@ Readable.prototype.wrap = function(stream) {
   }
 
   // Proxy certain important events.
-  for (var n = 0; n < kProxyEvents.length; n++) {
-    stream.on(kProxyEvents[n], this.emit.bind(this, kProxyEvents[n]));
+  for (const kProxyEvent of kProxyEvents) {
+    stream.on(kProxyEvent, this.emit.bind(this, kProxyEvent));
   }
 
   // When we try to consume some more bytes, simply unpause the