From 558d1e6c221e9392b5d2205e94a2c357067bd79c Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Fri, 26 Mar 2021 15:18:07 -0400 Subject: [PATCH] build: warn for gcc versions earlier than 8.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Update the warning threshold to match the minimum supported version of gcc. Builds can still proceed, but are not guaranteed to work. PR-URL: https://github.com/nodejs/node/pull/37935 Refs: https://github.com/nodejs/node/pull/37871 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso Reviewed-By: Darshan Sen Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- configure.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.py b/configure.py index b526507fee9fbb..784e21475dfa0e 100755 --- a/configure.py +++ b/configure.py @@ -960,8 +960,8 @@ def check_compiler(o): ('clang ' if is_clang else '', CXX, version_str)) if not ok: warn('failed to autodetect C++ compiler version (CXX=%s)' % CXX) - elif clang_version < (8, 0, 0) if is_clang else gcc_version < (6, 3, 0): - warn('C++ compiler (CXX=%s, %s) too old, need g++ 6.3.0 or clang++ 8.0.0' % + elif clang_version < (8, 0, 0) if is_clang else gcc_version < (8, 3, 0): + warn('C++ compiler (CXX=%s, %s) too old, need g++ 8.3.0 or clang++ 8.0.0' % (CXX, version_str)) ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c')