Skip to content

Commit

Permalink
test: http2 client setNextStreamID errors
Browse files Browse the repository at this point in the history
Backport-PR-URL: #18848
PR-URL: #18848
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
trivikr authored and MylesBorins committed Mar 20, 2018
1 parent f0f31d0 commit 519850f
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/internal/http2/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -948,7 +948,7 @@ class Http2Session extends EventEmitter {
if (typeof id !== 'number')
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'id', 'number');
if (id <= 0 || id > kMaxStreams)
throw new errors.RangeError('ERR_OUT_OF_RANGE');
throw new errors.RangeError('ERR_OUT_OF_RANGE', 'id');
this[kHandle].setNextStreamID(id);
}

Expand Down
58 changes: 58 additions & 0 deletions test/parallel/test-http2-client-setNextStreamID-errors.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
'use strict';

const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');

const http2 = require('http2');

const server = http2.createServer();
server.on('stream', (stream) => {
stream.respond();
stream.end('ok');
});

const types = {
boolean: true,
function: () => {},
number: 1,
object: {},
array: [],
null: null,
symbol: Symbol('test')
};

server.listen(0, common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);

client.on('connect', () => {
const outOfRangeNum = 2 ** 31;
common.expectsError(
() => client.setNextStreamID(outOfRangeNum),
{
type: RangeError,
code: 'ERR_OUT_OF_RANGE',
message: 'The "id" argument is out of range'
}
);

// should throw if something other than number is passed to setNextStreamID
Object.entries(types).forEach(([type, value]) => {
if (type === 'number') {
return;
}

common.expectsError(
() => client.setNextStreamID(value),
{
type: TypeError,
code: 'ERR_INVALID_ARG_TYPE',
message: 'The "id" argument must be of type number'
}
);
});

server.close();
client.close();
});
}));

0 comments on commit 519850f

Please sign in to comment.