lib: add FormData global when fetch is enabled

PR-URL: #41956 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs · Feb 21, 2022 · 4fbe064 · 4fbe064
1 parent ce23738
commit 4fbe064
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 1 deletion.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -319,6 +319,7 @@ module.exports = {
     Crypto: 'readable',
     CryptoKey: 'readable',
     fetch: 'readable',
+    FormData: 'readable',
     globalThis: 'readable',
     Response: 'readable',
     SubtleCrypto: 'readable',

diff --git a/doc/api/globals.md b/doc/api/globals.md
@@ -363,6 +363,17 @@ added: v17.5.0
 
 A browser-compatible implementation of the [`fetch()`][] function.
 
+## Class `FormData`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+> Stability: 1 - Experimental. Enable this API with the [`--experimental-fetch`][]
+> CLI flag.
+
+A browser-compatible implementation of {FormData}.
+
 ## `global`
 
 <!-- YAML

diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
@@ -47,6 +47,8 @@ rules:
       message: Use `const { Event } = require('internal/event_target');` instead of the global.
     - name: EventTarget
       message: Use `const { EventTarget } = require('internal/event_target');` instead of the global.
+    - name: FormData
+      message: Use `const { FormData } = require('internal/deps/undici/undici');` instead of the global.
     - name: Headers
       message: Use `const { Headers } = require('internal/deps/undici/undici');` instead of the global.
       # Intl is not available in primordials because it can be

diff --git a/lib/internal/bootstrap/pre_execution.js b/lib/internal/bootstrap/pre_execution.js
@@ -163,6 +163,12 @@ function setupFetch() {
     configurable: true,
     value: undici.fetch
   });
+  ObjectDefineProperty(globalThis, 'FormData', {
+    writable: true,
+    enumerable: false,
+    configurable: true,
+    value: undici.FormData
+  });
   ObjectDefineProperty(globalThis, 'Headers', {
     writable: true,
     enumerable: false,

diff --git a/test/common/index.js b/test/common/index.js
@@ -303,6 +303,7 @@ if (global.structuredClone) {
 if (global.fetch) {
   knownGlobals.push(
     global.fetch,
+    global.FormData,
     global.Request,
     global.Response,
     global.Headers,

diff --git a/test/parallel/test-fetch.mjs b/test/parallel/test-fetch.mjs
@@ -7,6 +7,7 @@ import events from 'events';
 import http from 'http';
 
 assert.strictEqual(typeof globalThis.fetch, 'function');
+assert.strictEqual(typeof globalThis.FormData, 'function');
 assert.strictEqual(typeof globalThis.Headers, 'function');
 assert.strictEqual(typeof globalThis.Request, 'function');
 assert.strictEqual(typeof globalThis.Response, 'function');

diff --git a/test/wpt/test-url.js b/test/wpt/test-url.js
@@ -11,7 +11,7 @@ runner.setScriptModifier((obj) => {
     // created via `document.createElement`. So we need to ignore them and just
     // test `URL`.
     obj.code = obj.code.replace(/\["url", "a", "area"\]/, '[ "url" ]');
-  } else if (typeof FormData === 'undefined' && // eslint-disable-line
+  } else if (typeof FormData === 'undefined' &&
       obj.filename.includes('urlsearchparams-constructor.any.js')) {
     // TODO(XadillaX): Remove this `else if` after `FormData` is supported.
 

diff --git a/tools/doc/type-parser.mjs b/tools/doc/type-parser.mjs
@@ -271,6 +271,7 @@ const customTypesMap = {
   'TextDecoderStream':
     'webstreams.md#class-textdecoderstream',
 
+  'FormData': 'https://developer.mozilla.org/en-US/docs/Web/API/FormData',
   'Headers': 'https://developer.mozilla.org/en-US/docs/Web/API/Headers',
   'Response': 'https://developer.mozilla.org/en-US/docs/Web/API/Response',
   'Request': 'https://developer.mozilla.org/en-US/docs/Web/API/Request',