zlib: move process.binding('zlib') to internalBinding

PR-URL: #23307 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
nodejs · Oct 17, 2018 · 4f48ddb · 4f48ddb
1 parent 37e40e3
commit 4f48ddb
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -412,7 +412,8 @@
         'async_wrap',
         'url',
         'spawn_sync',
-        'js_stream']);
+        'js_stream',
+        'zlib']);
     process.binding = function binding(name) {
       return internalBindingWhitelist.has(name) ?
         internalBinding(name) :

diff --git a/lib/zlib.js b/lib/zlib.js
@@ -36,7 +36,7 @@ const {
     isArrayBufferView
   }
 } = require('util');
-const binding = process.binding('zlib');
+const binding = internalBinding('zlib');
 const assert = require('assert').ok;
 const {
   Buffer,

diff --git a/src/node_zlib.cc b/src/node_zlib.cc
@@ -850,4 +850,4 @@ void DefineZlibConstants(Local<Object> target) {
 
 }  // namespace node
 
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(zlib, node::Initialize)
+NODE_MODULE_CONTEXT_AWARE_INTERNAL(zlib, node::Initialize)
diff --git a/test/async-hooks/test-zlib.zlib-binding.deflate.js b/test/async-hooks/test-zlib.zlib-binding.deflate.js
@@ -1,3 +1,4 @@
+// Flags: --expose-internals
 'use strict';
 
 const common = require('../common');
@@ -8,7 +9,8 @@ const { checkInvocations } = require('./hook-checks');
 const hooks = initHooks();
 
 hooks.enable();
-const Zlib = process.binding('zlib').Zlib;
+const { internalBinding } = require('internal/test/binding');
+const { Zlib } = internalBinding('zlib');
 const constants = process.binding('constants').zlib;
 
 const handle = new Zlib(constants.DEFLATE);