test: invalid package.json causes error when require()ing in directory

Requiring a file from a directory that contains an invalid package.json file should throw an error. PR-URL: #10044 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Dec 7, 2016 · 4f486aa · 4f486aa
1 parent 00ea286
commit 4f486aa
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/test/fixtures/packages/invalid/index.js b/test/fixtures/packages/invalid/index.js
@@ -0,0 +1 @@
+exports.ok = 'ok';
diff --git a/test/fixtures/packages/invalid/package.json b/test/fixtures/packages/invalid/package.json
@@ -0,0 +1 @@
+{,}
diff --git a/test/sequential/test-module-loading.js b/test/sequential/test-module-loading.js
@@ -69,6 +69,13 @@ assert.strictEqual(threeFolder, threeIndex);
 assert.notStrictEqual(threeFolder, three);
 
 console.error('test package.json require() loading');
+assert.throws(
+  function() {
+    require('../fixtures/packages/invalid');
+  },
+  /^SyntaxError: Error parsing \S+: Unexpected token , in JSON at position 1$/
+);
+
 assert.strictEqual(require('../fixtures/packages/index').ok, 'ok',
                    'Failed loading package');
 assert.strictEqual(require('../fixtures/packages/main').ok, 'ok',