From 4aabd7ed641db5d78fdf7e1c93b93027ffc3a9b4 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Fri, 7 Dec 2018 14:58:09 +0100 Subject: [PATCH] doc: simplify author ready The label should be applied early on. Otherwise there is little benefit using this label at all. PR-URL: https://github.com/nodejs/node/pull/24893 Reviewed-By: Vse Mozhet Byt Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Denys Otrishko Reviewed-By: Franziska Hinkelmann --- COLLABORATOR_GUIDE.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 2bce29e5645e9b..de776bbaaa04d9 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -72,8 +72,7 @@ issues and pull requests can always be re-opened if necessary. A pull request is _author ready_ when: * There is a CI run in progress or completed. -* There are at least two Collaborator approvals, or at least one approval if the - pull request is older than 7 days. +* There is at least one Collaborator approval. * There are no outstanding review comments. Please always add the `author ready` label to the pull request in that case.