stream: allow empty string as source of pipeline

Fixes: #38721 PR-URL: #38723 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
nodejs · May 31, 2021 · 4131f94 · 4131f94
1 parent 496f7ea
commit 4131f94
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/internal/streams/utils.js b/lib/internal/streams/utils.js
@@ -20,7 +20,7 @@ function isStream(obj) {
 }
 
 function isIterable(obj, isAsync) {
-  if (!obj) return false;
+  if (obj == null) return false;
   if (isAsync === true) return typeof obj[SymbolAsyncIterator] === 'function';
   if (isAsync === false) return typeof obj[SymbolIterator] === 'function';
   return typeof obj[SymbolAsyncIterator] === 'function' ||

diff --git a/test/parallel/test-stream-pipeline-with-empty-string.js b/test/parallel/test-stream-pipeline-with-empty-string.js
@@ -0,0 +1,18 @@
+'use strict';
+
+const common = require('../common');
+const {
+  pipeline,
+  PassThrough
+} = require('stream');
+
+
+async function runTest() {
+  await pipeline(
+    '',
+    new PassThrough({ objectMode: true }),
+    common.mustCall(() => { })
+  );
+}
+
+runTest().then(common.mustCall(() => {}));