report: remove InitializeReport()

PR-URL: #25598 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
nodejs · Jan 24, 2019 · 4031b5c · 4031b5c
1 parent 0ebe6eb
commit 4031b5c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 21 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -728,12 +728,6 @@ void RunBootstrapping(Environment* env) {
     return;
   }
 
-#ifdef NODE_REPORT
-  if (env->options()->experimental_report) {
-    report::InitializeReport(env->isolate(), env);
-  }
-#endif  // NODE_REPORT
-
   // process, loaderExports, isMainThread
   std::vector<Local<String>> node_params = {
       env->process_string(),

diff --git a/src/node_report.h b/src/node_report.h
@@ -38,8 +38,6 @@ typedef struct tm TIME_TYPE;
 #define PATHSEP "/"
 #endif
 
-void InitializeReport(v8::Isolate* isolate, node::Environment* env);
-
 // Function declarations - functions in src/node_report.cc
 std::string TriggerNodeReport(v8::Isolate* isolate,
                               node::Environment* env,

diff --git a/src/node_report_module.cc b/src/node_report_module.cc
@@ -108,15 +108,6 @@ void OnUserSignal(const FunctionCallbackInfo<Value>& info) {
       isolate, env, *value, __func__, filename, info[0].As<String>());
 }
 
-// Native module initializer function, called when the module is require'd
-void InitializeReport(Isolate* isolate, Environment* env) {
-  // Register the boot time of the process, for
-  // computing resource consumption average etc.
-  std::shared_ptr<PerIsolateOptions> options = env->isolate_data()->options();
-
-  if (options->report_signal == "") options->report_signal = "SIGUSR2";
-}
-
 // A method to sync up data elements in the JS land with its
 // corresponding elements in the C++ world. Required because
 // (i) the tunables are first intercepted through the CLI but
@@ -236,8 +227,9 @@ void SyncConfig(const FunctionCallbackInfo<Value>& info) {
     Local<Value> signal_value;
     Local<Value> file_value;
     Local<Value> path_value;
-    if (!node::ToV8Value(context, options->report_signal)
-             .ToLocal(&signal_value))
+    std::string signal = options->report_signal;
+    if (signal.empty()) signal = "SIGUSR2";
+    if (!node::ToV8Value(context, signal).ToLocal(&signal_value))
       return;
     if (!obj->Set(context, signalkey, signal_value).FromJust()) return;
 
@@ -264,8 +256,6 @@ static void Initialize(Local<Object> exports,
                        Local<Context> context) {
   Environment* env = Environment::GetCurrent(context);
   std::shared_ptr<PerIsolateOptions> options = env->isolate_data()->options();
-  Isolate* isolate = env->isolate();
-  InitializeReport(isolate, env);
   env->SetMethod(exports, "triggerReport", TriggerReport);
   env->SetMethod(exports, "getReport", GetReport);
   env->SetMethod(exports, "onUnCaughtException", OnUncaughtException);