Skip to content

Commit

Permalink
doc: remove "make that" from onboarding.md
Browse files Browse the repository at this point in the history
Refs: nodejs/remark-preset-lint-node#16

PR-URL: #28329
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
  • Loading branch information
Trott authored and targos committed Jul 2, 2019
1 parent 79f23b5 commit 3daced7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions doc/onboarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ onboarding session.
* Be aware: Your opinion carries a lot of weight!
* Nits (requests for small changes that are not essential) are fine, but try to
avoid stalling the pull request.
* Note that they are nits when you comment: `Nit: change foo() to bar().`
* Identify them as nits when you comment: `Nit: change foo() to bar().`
* If they are stalling the pull request, fix them yourself on merge.
* Insofar as possible, issues should be identified by tools rather than human
reviewers. If you are leaving comments about issues that could be identified
Expand Down Expand Up @@ -191,7 +191,7 @@ onboarding session.

See the Collaborator Guide: [Landing Pull Requests][].

Note that commits in one PR that belong to one logical change should
Commits in one PR that belong to one logical change should
be squashed. It is rarely the case in onboarding exercises, so this
needs to be pointed out separately during the onboarding.

Expand Down

0 comments on commit 3daced7

Please sign in to comment.