stream: drain Transform with 0 highWaterMark

Fixes: #40935 PR-URL: #40947 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
nodejs · Feb 1, 2022 · 3b1c012 · 3b1c012
1 parent 90ac3dc
commit 3b1c012
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/internal/streams/transform.js b/lib/internal/streams/transform.js
@@ -196,6 +196,7 @@ Transform.prototype._write = function(chunk, encoding, callback) {
       wState.ended || // Backwards compat.
       length === rState.length || // Backwards compat.
       rState.length < rState.highWaterMark ||
+      rState.highWaterMark === 0 ||
       rState.length === 0
     ) {
       callback();

diff --git a/test/parallel/test-stream-passthrough-drain.js b/test/parallel/test-stream-passthrough-drain.js
@@ -0,0 +1,8 @@
+'use strict';
+const common = require('../common');
+const { PassThrough } = require('stream');
+
+const pt = new PassThrough({ highWaterMark: 0 });
+pt.on('drain', common.mustCall());
+pt.write('hello');
+pt.read();