From 3b0c244036f2efc5b6896663463ea3c8afbd222f Mon Sep 17 00:00:00 2001 From: Tony Gorez Date: Fri, 27 Jan 2023 10:28:55 +0100 Subject: [PATCH] doc: fix commit message using test instead of deps MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/46313 Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen Reviewed-By: Michaël Zasso Reviewed-By: Gireesh Punathil Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca --- .github/workflows/tools.yml | 4 ++-- doc/contributing/maintaining-postject.md | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/tools.yml b/.github/workflows/tools.yml index a056aa705bd246..ab7902eec9709e 100644 --- a/.github/workflows/tools.yml +++ b/.github/workflows/tools.yml @@ -78,8 +78,8 @@ jobs: ./tools/update-undici.sh fi - id: postject - subsystem: deps - label: dependencies + subsystem: test + label: test run: | NEW_VERSION=$(npm view postject dist-tags.latest) CURRENT_VERSION=$(node -p "require('./test/fixtures/postject-copy/node_modules/postject/package.json').version") diff --git a/doc/contributing/maintaining-postject.md b/doc/contributing/maintaining-postject.md index 96746e22796900..d01dc318e51c5c 100644 --- a/doc/contributing/maintaining-postject.md +++ b/doc/contributing/maintaining-postject.md @@ -12,12 +12,12 @@ Check that Node.js still builds and tests. ## Committing postject -Add postject: `git add --all test/fixtures/postject-copy` +1. Add postject: `git add --all test/fixtures/postject-copy`. +2. Commit the changes: `git commit`. +3. Add a message like: -Commit the changes with a message like: + ```text + test: update postject to -```text -deps: update postject to 1.0.0-alpha.4 - -Updated as described in doc/contributing/maintaining-postject.md. -``` + Updated as described in doc/contributing/maintaining-postject.md. + ```