From 38fd7902efac9011a98fc75d319889efe6025459 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 17 Jan 2018 22:55:23 +0100 Subject: [PATCH] tty: fix console printing on Windows This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7eb7b05a0b27f52e2288a636fdd78e9ecb. Fixes: https://github.com/nodejs/node/issues/18189 Refs: https://github.com/nodejs/node/pull/18019 PR-URL: https://github.com/nodejs/node/pull/18214 Fixes: https://github.com/nodejs/node/issues/18189 Refs: https://github.com/nodejs/node/pull/18019 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig --- lib/tty.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/tty.js b/lib/tty.js index 7b93309efc3d99..9595c79db39a33 100644 --- a/lib/tty.js +++ b/lib/tty.js @@ -24,7 +24,6 @@ const util = require('util'); const net = require('net'); const { TTY, isTTY } = process.binding('tty_wrap'); -const { makeSyncWrite } = require('internal/net'); const { inherits } = util; const errnoException = util._errnoException; const errors = require('internal/errors'); @@ -80,8 +79,6 @@ function WriteStream(fd) { // even though it was originally intended to change in v1.0.2 (Libuv 1.2.1). // Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671 this._handle.setBlocking(true); - this._writev = null; - this._write = makeSyncWrite(fd); var winSize = new Array(2); var err = this._handle.getWindowSize(winSize);