fixup! fixup! fixup! stream: add iterator helper find

nodejs · Feb 4, 2022 · 388099e · 388099e
1 parent 0562664
commit 388099e
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 0 deletions.
diff --git a/test/parallel/test-stream-filter.js b/test/parallel/test-stream-filter.js
@@ -98,3 +98,9 @@ const { setTimeout } = require('timers/promises');
   const stream = Readable.from([1, 2, 3, 4, 5]).filter((x) => true);
   assert.strictEqual(stream.readable, true);
 }
+{
+  const stream = Readable.from([1, 2, 3, 4, 5]);
+  stream.map = common.mustNotCall(() => {});
+  // Check that map isn't getting called.
+  stream.filter(() => true);
+}
diff --git a/test/parallel/test-stream-flatMap.js b/test/parallel/test-stream-flatMap.js
@@ -121,3 +121,9 @@ function oneTo5() {
   const stream = oneTo5().flatMap((x) => x);
   assert.strictEqual(stream.readable, true);
 }
+{
+  const stream = oneTo5();
+  stream.map = common.mustNotCall(() => {});
+  // Check that map isn't getting called.
+  stream.flatMap(() => true);
+}
diff --git a/test/parallel/test-stream-forEach.js b/test/parallel/test-stream-forEach.js
@@ -84,3 +84,9 @@ const { setTimeout } = require('timers/promises');
   const stream = Readable.from([1, 2, 3, 4, 5]).forEach((_) => true);
   assert.strictEqual(typeof stream.then, 'function');
 }
+{
+  const stream = Readable.from([1, 2, 3, 4, 5]);
+  stream.map = common.mustNotCall(() => {});
+  // Check that map isn't getting called.
+  stream.forEach(() => true);
+}
diff --git a/test/parallel/test-stream-some-find-every.mjs b/test/parallel/test-stream-some-find-every.mjs
@@ -162,3 +162,11 @@ function oneTo5Async() {
     }, /ERR_INVALID_ARG_TYPE/, `${op} should throw for invalid signal`).then(common.mustCall());
   }
 }
+{
+  for (const op of ['some', 'every', 'find']) {
+    const stream = oneTo5();
+    stream.map = common.mustNotCall(() => {});
+    // Check that map isn't getting called.
+    stream[op](() => {});
+  }
+}