From 380600dbe57e87d440543a402ea2af90f2e4aa4a Mon Sep 17 00:00:00 2001 From: Mary Marchini Date: Sun, 9 Aug 2020 22:53:22 -0700 Subject: [PATCH] build: set --v8-enable-object-print by default The flag improves the experience of debugging V8 with native debuggers. It doens't incur performance penality, the only downside is an increase in binary size by approximately 248 Kb. Ref: https://github.com/nodejs/node/pull/32834 PR-URL: https://github.com/nodejs/node/pull/34705 Reviewed-By: Jiawen Geng Reviewed-By: David Carlier --- common.gypi | 3 +++ configure.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index 0dc9b046298aff..da7758afc4c3c3 100644 --- a/common.gypi +++ b/common.gypi @@ -55,6 +55,9 @@ # Enable disassembler for `--print-code` v8 options 'v8_enable_disassembler': 1, + # Sets -dOBJECT_PRINT. + 'v8_enable_object_print%': 1, + # https://github.com/nodejs/node/pull/22920/files#r222779926 'v8_enable_handle_zapping': 0, diff --git a/configure.py b/configure.py index 77369a52045ad6..c38a4a1881eda1 100755 --- a/configure.py +++ b/configure.py @@ -651,7 +651,7 @@ parser.add_option('--v8-enable-object-print', action='store_true', dest='v8_enable_object_print', - default=False, + default=True, help='compile V8 with auxiliar functions for native debuggers') parser.add_option('--node-builtin-modules-path',