From 357eaf3c9569e444628f169267040814a61958f2 Mon Sep 17 00:00:00 2001
From: cjihrig <cjihrig@gmail.com>
Date: Sun, 20 May 2018 15:16:25 -0400
Subject: [PATCH] test: lint fixes for ESLint update

This commit introduces changes required for the ESLint 5 update.

PR-URL: https://github.com/nodejs/node/pull/20855
Reviewed-By: Rich Trott <rtrott@gmail.com>
---
 test/es-module/test-esm-forbidden-globals.mjs | 1 +
 test/parallel/test-console-is-a-namespace.js  | 3 ++-
 test/parallel/test-http2-socket-proxy.js      | 4 ++--
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/test/es-module/test-esm-forbidden-globals.mjs b/test/es-module/test-esm-forbidden-globals.mjs
index 840a7ea54138fe..4e777412a346fd 100644
--- a/test/es-module/test-esm-forbidden-globals.mjs
+++ b/test/es-module/test-esm-forbidden-globals.mjs
@@ -1,6 +1,7 @@
 // Flags: --experimental-modules
 import '../common';
 
+// eslint-disable-next-line no-undef
 if (typeof arguments !== 'undefined') {
   throw new Error('not an ESM');
 }
diff --git a/test/parallel/test-console-is-a-namespace.js b/test/parallel/test-console-is-a-namespace.js
index 95c652abdd4424..82665411879ca9 100644
--- a/test/parallel/test-console-is-a-namespace.js
+++ b/test/parallel/test-console-is-a-namespace.js
@@ -5,7 +5,8 @@ require('../common');
 const { test, assert_equals, assert_true, assert_false } =
   require('../common/wpt');
 
-global.console = global.console; // Should not throw.
+// Assigning to itself should not throw.
+global.console = global.console; // eslint-disable-line no-self-assign
 
 const self = global;
 
diff --git a/test/parallel/test-http2-socket-proxy.js b/test/parallel/test-http2-socket-proxy.js
index 71429b3db2f196..f7d97a3bb11e8a 100644
--- a/test/parallel/test-http2-socket-proxy.js
+++ b/test/parallel/test-http2-socket-proxy.js
@@ -52,8 +52,8 @@ server.on('stream', common.mustCall(function(stream, headers) {
   common.expectsError(() => (socket.write = undefined), errMsg);
 
   // Resetting the socket listeners to their own value should not throw.
-  socket.on = socket.on;
-  socket.once = socket.once;
+  socket.on = socket.on;  // eslint-disable-line no-self-assign
+  socket.once = socket.once;  // eslint-disable-line no-self-assign
 
   stream.respond();