-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: Modernize test-tls-peer-certificate.js
Modernize `test/parallel/test-tls-peer-certificate.js` according to the following rules: * `var` --> `const`/`let` * `assert.equal` --> `assert.strictEqual` * `assert.ok(a === b)` --> `assert.strictEqual(a, b)` PR-URL: #10014 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-by: Michael Dawson <[email protected]>
- Loading branch information
1 parent
f55a63c
commit 34b8c86
Showing
1 changed file
with
20 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,50 +1,52 @@ | ||
'use strict'; | ||
var common = require('../common'); | ||
var assert = require('assert'); | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
|
||
if (!common.hasCrypto) { | ||
common.skip('missing crypto'); | ||
return; | ||
} | ||
var tls = require('tls'); | ||
const tls = require('tls'); | ||
|
||
var fs = require('fs'); | ||
var util = require('util'); | ||
var join = require('path').join; | ||
const fs = require('fs'); | ||
const util = require('util'); | ||
const join = require('path').join; | ||
|
||
var options = { | ||
const options = { | ||
key: fs.readFileSync(join(common.fixturesDir, 'keys', 'agent1-key.pem')), | ||
cert: fs.readFileSync(join(common.fixturesDir, 'keys', 'agent1-cert.pem')), | ||
ca: [ fs.readFileSync(join(common.fixturesDir, 'keys', 'ca1-cert.pem')) ] | ||
}; | ||
|
||
var server = tls.createServer(options, function(cleartext) { | ||
const server = tls.createServer(options, function(cleartext) { | ||
cleartext.end('World'); | ||
}); | ||
server.listen(0, common.mustCall(function() { | ||
var socket = tls.connect({ | ||
const socket = tls.connect({ | ||
port: this.address().port, | ||
rejectUnauthorized: false | ||
}, common.mustCall(function() { | ||
var peerCert = socket.getPeerCertificate(); | ||
let peerCert = socket.getPeerCertificate(); | ||
assert.ok(!peerCert.issuerCertificate); | ||
|
||
// Verify that detailed return value has all certs | ||
peerCert = socket.getPeerCertificate(true); | ||
assert.ok(peerCert.issuerCertificate); | ||
|
||
console.error(util.inspect(peerCert)); | ||
assert.equal(peerCert.subject.emailAddress, '[email protected]'); | ||
assert.equal(peerCert.serialNumber, '9A84ABCFB8A72AC0'); | ||
assert.equal(peerCert.exponent, '0x10001'); | ||
assert.equal(peerCert.fingerprint, | ||
'8D:06:3A:B3:E5:8B:85:29:72:4F:7D:1B:54:CD:95:19:3C:EF:6F:AA'); | ||
assert.strictEqual(peerCert.subject.emailAddress, '[email protected]'); | ||
assert.strictEqual(peerCert.serialNumber, '9A84ABCFB8A72AC0'); | ||
assert.strictEqual(peerCert.exponent, '0x10001'); | ||
assert.strictEqual( | ||
peerCert.fingerprint, | ||
'8D:06:3A:B3:E5:8B:85:29:72:4F:7D:1B:54:CD:95:19:3C:EF:6F:AA' | ||
); | ||
assert.deepStrictEqual(peerCert.infoAccess['OCSP - URI'], | ||
[ 'http://ocsp.nodejs.org/' ]); | ||
|
||
var issuer = peerCert.issuerCertificate; | ||
assert.ok(issuer.issuerCertificate === issuer); | ||
assert.equal(issuer.serialNumber, '8DF21C01468AF393'); | ||
const issuer = peerCert.issuerCertificate; | ||
assert.strictEqual(issuer.issuerCertificate, issuer); | ||
assert.strictEqual(issuer.serialNumber, '8DF21C01468AF393'); | ||
server.close(); | ||
})); | ||
socket.end('Hello'); | ||
|