From 32a2a6049d23706986d423abaa31fb64723ba8b7 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 29 Feb 2016 17:44:31 -0500 Subject: [PATCH] test: allow options for v8 testing Allow extra options when testing v8 in Node tree PR-URL: https://github.com/nodejs/node/pull/5502 Reviewed-By: Ben Noordhuis --- Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index d551ef2e446288..fc9de645c9c327 100644 --- a/Makefile +++ b/Makefile @@ -21,8 +21,9 @@ ifdef ENABLE_V8_TAP TAP_V8_BENCHMARKS := --junitout v8-benchmarks-tap.xml endif +V8_TEST_OPTIONS = $(V8_EXTRA_TEST_OPTIONS) ifdef DISABLE_V8_I18N - V8_TEST_NO_I18N := --noi18n + V8_TEST_OPTIONS += --noi18n V8_BUILD_OPTIONS += i18nsupport=off endif @@ -210,7 +211,7 @@ test-timers-clean: test-v8: # note: performs full test unless QUICKCHECK is specified deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \ - --mode=$(BUILDTYPE_LOWER) $(V8_TEST_NO_I18N) $(QUICKCHECK_ARG) \ + --mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) $(QUICKCHECK_ARG) \ --no-presubmit \ --shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \ $(TAP_V8)