esm: avoid accessing lazy getters for urls

PR-URL: #47542 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Jul 6, 2023 · 316016f · 316016f
1 parent 61ea153
commit 316016f
Showing 1 changed file with 25 additions and 15 deletions.
diff --git a/lib/internal/modules/esm/resolve.js b/lib/internal/modules/esm/resolve.js
@@ -994,16 +994,20 @@ function resolveAsCommonJS(specifier, parentURL) {
 // TODO(@JakobJingleheimer): de-dupe `specifier` & `parsed`
 function checkIfDisallowedImport(specifier, parsed, parsedParentURL) {
   if (parsedParentURL) {
+    // Avoid accessing the `protocol` property due to the lazy getters.
+    const parentProtocol = parsedParentURL.protocol;
     if (
-      parsedParentURL.protocol === 'http:' ||
-      parsedParentURL.protocol === 'https:'
+      parentProtocol === 'http:' ||
+      parentProtocol === 'https:'
     ) {
       if (shouldBeTreatedAsRelativeOrAbsolutePath(specifier)) {
+        // Avoid accessing the `protocol` property due to the lazy getters.
+        const parsedProtocol = parsed?.protocol;
         // data: and blob: disallowed due to allowing file: access via
         // indirection
-        if (parsed &&
-          parsed.protocol !== 'https:' &&
-          parsed.protocol !== 'http:'
+        if (parsedProtocol &&
+          parsedProtocol !== 'https:' &&
+          parsedProtocol !== 'http:'
         ) {
           throw new ERR_NETWORK_IMPORT_DISALLOWED(
             specifier,
@@ -1033,22 +1037,26 @@ function checkIfDisallowedImport(specifier, parsed, parsedParentURL) {
 }
 
 function throwIfUnsupportedURLProtocol(url) {
-  if (url.protocol !== 'file:' && url.protocol !== 'data:' &&
-      url.protocol !== 'node:') {
+  // Avoid accessing the `protocol` property due to the lazy getters.
+  const protocol = url.protocol;
+  if (protocol !== 'file:' && protocol !== 'data:' &&
+      protocol !== 'node:') {
     throw new ERR_UNSUPPORTED_ESM_URL_SCHEME(url);
   }
 }
 
 function throwIfUnsupportedURLScheme(parsed, experimentalNetworkImports) {
+  // Avoid accessing the `protocol` property due to the lazy getters.
+  const protocol = parsed?.protocol;
   if (
-    parsed &&
-    parsed.protocol !== 'file:' &&
-    parsed.protocol !== 'data:' &&
+    protocol &&
+    protocol !== 'file:' &&
+    protocol !== 'data:' &&
     (
       !experimentalNetworkImports ||
       (
-        parsed.protocol !== 'https:' &&
-        parsed.protocol !== 'http:'
+        protocol !== 'https:' &&
+        protocol !== 'http:'
       )
     )
   ) {
@@ -1104,11 +1112,13 @@ async function defaultResolve(specifier, context = {}) {
       parsed = new URL(specifier);
     }
 
-    if (parsed.protocol === 'data:' ||
+    // Avoid accessing the `protocol` property due to the lazy getters.
+    const protocol = parsed.protocol;
+    if (protocol === 'data:' ||
       (experimentalNetworkImports &&
         (
-          parsed.protocol === 'https:' ||
-          parsed.protocol === 'http:'
+          protocol === 'https:' ||
+          protocol === 'http:'
         )
       )
     ) {