path: fix verbose relative() output

Fixes: #5383 PR-URL: #5389 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
nodejs · Feb 28, 2016 · 30cec18 · 30cec18
1 parent 378a772
commit 30cec18
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/path.js b/lib/path.js
@@ -1281,6 +1281,10 @@ const posix = {
           // We get here if `from` is the exact base path for `to`.
           // For example: from='/foo/bar'; to='/foo/bar/baz'
           return to.slice(i + 2);
+        } else if (fromLen > length && from.charCodeAt(i + 1) === 47/*/*/) {
+          // We get here if `to` is the exact base path for `from`.
+          // For example: from='/foo/bar/baz'; to='/foo/bar'
+          lastCommonSep = i;
         }
         break;
       }

diff --git a/test/parallel/test-path.js b/test/parallel/test-path.js
@@ -481,7 +481,8 @@ const relativeTests = [
      ['/var/lib', '/var/apache', '../apache'],
      ['/var/', '/var/lib', 'lib'],
      ['/', '/var/lib', 'var/lib'],
-     ['/foo/test', '/foo/test/bar/package.json', 'bar/package.json']
+     ['/foo/test', '/foo/test/bar/package.json', 'bar/package.json'],
+     ['/Users/a/web/b/test/mails', '/Users/a/web/b', '../..']
     ]
   ]
 ];