From 2eebece483f3643a41a745695468f19934187a8b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 3 Jul 2021 10:18:24 -0700 Subject: [PATCH] doc: remove GitHub mark Judging from https://github.com/logos, we are misusing the GitHub mark. That page indicates to not change the color (we change it from black to green). Less clear, it says "Use the Mark in social buttons to link to your GitHub profile or project" which isn't exactly what we're doing but also isn't not what we're doing? This might be an indication of my eyesight getting worse as I get older, but I think the size that we display the mark at by default makes it not entirely recognizable as the GitHub mark. Lastly, there's the philosophical issue of whether we should display a commercial entity's mark on our web pages in this particular instance. (For me, the answer is "maybe".) All told, I think we can remove it without damaging usability on the website, so let's do it. --- doc/api_assets/style.css | 5 ----- tools/doc/html.mjs | 4 +--- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/doc/api_assets/style.css b/doc/api_assets/style.css index 7bcd07b561c3da..768a64b266b5b9 100644 --- a/doc/api_assets/style.css +++ b/doc/api_assets/style.css @@ -679,11 +679,6 @@ kbd { visibility: hidden; } -.github_icon { - vertical-align: middle; - margin: -2px 3px 0 0; -} - /* API reference sidebar */ @media only screen and (min-width: 1025px) { .apidoc #column2 > .line { diff --git a/tools/doc/html.mjs b/tools/doc/html.mjs index d1662a08c44924..c2c3a7a1836e88 100644 --- a/tools/doc/html.mjs +++ b/tools/doc/html.mjs @@ -489,8 +489,6 @@ function altDocs(filename, docCreated, versions) { ` : ''; } -// eslint-disable-next-line max-len -const githubLogo = ''; function editOnGitHub(filename) { - return `
  • ${githubLogo}Edit on GitHub
  • `; + return `
  • Edit on GitHub
  • `; }