module: throw when invalid argument is passed to enableCompileCache()

PR-URL: #54971 Fixes: #54770 Fixes: #54465 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Oct 4, 2024 · 2dcf70c · 2dcf70c
1 parent f9b19d7
commit 2dcf70c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/node_modules.cc b/src/node_modules.cc
@@ -436,10 +436,13 @@ void BindingData::GetPackageScopeConfig(
 }
 
 void EnableCompileCache(const FunctionCallbackInfo<Value>& args) {
-  CHECK(args[0]->IsString());
   Isolate* isolate = args.GetIsolate();
   Local<Context> context = isolate->GetCurrentContext();
   Environment* env = Environment::GetCurrent(context);
+  if (!args[0]->IsString()) {
+    THROW_ERR_INVALID_ARG_TYPE(env, "cacheDir should be a string");
+    return;
+  }
   Utf8Value value(isolate, args[0]);
   CompileCacheEnableResult result = env->EnableCompileCache(*value);
   std::vector<Local<Value>> values = {

diff --git a/test/parallel/test-compile-cache-api-error.js b/test/parallel/test-compile-cache-api-error.js
@@ -0,0 +1,11 @@
+'use strict';
+
+// This tests module.enableCompileCache() throws when an invalid argument is passed.
+
+require('../common');
+const { enableCompileCache } = require('module');
+const assert = require('assert');
+
+for (const invalid of [0, null, false, () => {}, {}, []]) {
+  assert.throws(() => enableCompileCache(invalid), { code: 'ERR_INVALID_ARG_TYPE' });
+}