fs: fix when path is buffer on fs.symlinkSync

PR-URL: #34540 Fixes: #34514 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]>
nodejs · Jul 30, 2020 · 2c4f30d · 2c4f30d
1 parent 019ea07
commit 2c4f30d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/internal/fs/utils.js b/lib/internal/fs/utils.js
@@ -336,6 +336,7 @@ function preprocessSymlinkDestination(path, type, linkPath) {
     // No preprocessing is needed on Unix.
     return path;
   }
+  path = '' + path;
   if (type === 'junction') {
     // Junctions paths need to be absolute and \\?\-prefixed.
     // A relative target is relative to the link's parent directory.
@@ -347,7 +348,7 @@ function preprocessSymlinkDestination(path, type, linkPath) {
     return pathModule.toNamespacedPath(path);
   }
   // Windows symlinks don't tolerate forward slashes.
-  return ('' + path).replace(/\//g, '\\');
+  return path.replace(/\//g, '\\');
 }
 
 // Constructor for file stats.

diff --git a/test/parallel/test-fs-symlink.js b/test/parallel/test-fs-symlink.js
@@ -56,6 +56,10 @@ fs.symlink(linkData, linkPath, common.mustCall(function(err) {
     assert.ifError(err);
     assert.strictEqual(destination, linkData);
   }));
+
+  tmpdir.refresh();
+  // Fixes: https://github.com/nodejs/node/issues/34514
+  fs.symlinkSync(Buffer.from(linkData), linkPath);
 }));
 
 // Test invalid symlink