test: add missing assertion

This commit adds an assertion to an existing try...catch statement. Unfortunately, assert.throws() cannot be used because the operation succeeds on some platforms, throws EINVAL on some platforms, and throws ENOPROTOOPT on others. PR-URL: #15519 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Oct 25, 2017 · 2a53165 · 2a53165
1 parent db8c92f
commit 2a53165
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/test/parallel/test-dgram-multicast-set-interface.js b/test/parallel/test-dgram-multicast-set-interface.js
@@ -33,11 +33,14 @@ const dgram = require('dgram');
   socket.bind(0);
   socket.on('listening', common.mustCall(() => {
     // Try to set with an invalid interfaceAddress (wrong address class)
+    //
+    // This operation succeeds on some platforms, throws `EINVAL` on some
+    // platforms, and throws `ENOPROTOOPT` on others. This is unpleasant, but
+    // we should at least test for it.
     try {
       socket.setMulticastInterface('::');
-      throw new Error('Not detected.');
     } catch (e) {
-      console.error(`setMulticastInterface: wrong family error is: ${e}`);
+      assert(e.code === 'EINVAL' || e.code === 'ENOPROTOOPT');
     }
 
     socket.close();