From 28d3f1963a98ce157b360c0a3ba70fb8e1f73f60 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Wed, 12 Jun 2019 02:38:14 +0800 Subject: [PATCH] build: turn on custom V8 snapshot by default MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch re-enables custom V8 snapshot integration. Also renames the experimental configure switch from `--with-node-snapshot` to `--without-node-snapshot` to be consistent with`--without-snapshot` which is used for the default V8 snapshot. PR-URL: https://github.com/nodejs/node/pull/28181 Refs: https://github.com/nodejs/node/pull/27365 Refs: https://github.com/nodejs/node/issues/17058 Reviewed-By: Michaël Zasso Reviewed-By: Gus Caplan Reviewed-By: Anna Henningsen Reviewed-By: Refael Ackermann (רפאל פלחי) Reviewed-By: Ben Noordhuis Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Rich Trott --- configure.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/configure.py b/configure.py index 9d9f0aec0b802f..b1a04742f00f2a 100755 --- a/configure.py +++ b/configure.py @@ -421,10 +421,10 @@ dest='with_ltcg', help='Use Link Time Code Generation. This feature is only available on Windows.') -parser.add_option('--with-node-snapshot', +parser.add_option('--without-node-snapshot', action='store_true', - dest='with_node_snapshot', - help='Turn on V8 snapshot integration. Currently experimental.') + dest='without_node_snapshot', + help='Turn off V8 snapshot integration. Currently experimental.') intl_optgroup.add_option('--download', action='store', @@ -942,11 +942,9 @@ def configure_node(o): o['variables']['want_separate_host_toolset'] = int( cross_compiling and want_snapshots) - if options.with_node_snapshot: - o['variables']['node_use_node_snapshot'] = 'true' + if not options.without_node_snapshot: + o['variables']['node_use_node_snapshot'] = b(not cross_compiling) else: - # Default to false for now. - # TODO(joyeecheung): enable it once we fix the hashseed uniqueness o['variables']['node_use_node_snapshot'] = 'false' if target_arch == 'arm':