Revert "http: do not leak error listeners"

This reverts commit 736a7d8. The patch attempted to fix an issue, signaled by a warning, caused by an invalid API usage. However it introduced a behavior change that is breaking userland modules. It is a user error, so restore the original behavior and have the user investigate and fix the issue in their code. Refs: #43587 (comment) Refs: #43587 (comment) PR-URL: #44921 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
nodejs · Jan 3, 2023 · 2882e60 · 2882e60
1 parent 8c2d0f9
commit 2882e60
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 48 deletions.
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -813,10 +813,7 @@ const requestHeaderFieldsTooLargeResponse = Buffer.from(
 function socketOnError(e) {
   // Ignore further errors
   this.removeListener('error', socketOnError);
-
-  if (this.listenerCount('error') === 0) {
-    this.on('error', noop);
-  }
+  this.on('error', noop);
 
   if (!this.server.emit('clientError', e, this)) {
     // Caution must be taken to avoid corrupting the remote peer.

diff --git a/test/parallel/test-http-socket-listeners.js b/test/parallel/test-http-socket-listeners.js