Skip to content

Commit

Permalink
tools,gyp: fix regex for version matching
Browse files Browse the repository at this point in the history
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
  • Loading branch information
Trott authored and evanlucas committed Jun 12, 2018
1 parent 4de7e0c commit 1e49ead
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/gyp/pylib/gyp/xcode_emulation.py
Original file line number Diff line number Diff line change
Expand Up @@ -1403,7 +1403,7 @@ def XcodeVersion():
except:
version = CLTVersion()
if version:
version = re.match(r'(\d\.\d\.?\d*)', version).groups()[0]
version = re.match(r'(\d+\.\d+\.?\d*)', version).groups()[0]
else:
raise GypError("No Xcode or CLT version detected!")
# The CLT has no build information, so we return an empty string.
Expand Down

0 comments on commit 1e49ead

Please sign in to comment.