From 1e20b05acdeb450bcc45b059954fe629db9b88f8 Mon Sep 17 00:00:00 2001
From: James M Snell <jasnell@gmail.com>
Date: Sun, 22 Jan 2023 12:14:11 -0800
Subject: [PATCH] url: implement URLSearchParams size getter
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Refs: https://github.com/whatwg/url/pull/734
PR-URL: https://github.com/nodejs/node/pull/46308
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
---
 doc/api/url.md                              | 8 ++++++++
 lib/internal/url.js                         | 7 +++++++
 test/parallel/test-whatwg-url-properties.js | 8 ++++++++
 3 files changed, 23 insertions(+)

diff --git a/doc/api/url.md b/doc/api/url.md
index e250b144987fa0..a10b5947c40eda 100644
--- a/doc/api/url.md
+++ b/doc/api/url.md
@@ -940,6 +940,14 @@ console.log(params.toString());
 // Prints foo=def&abc=def&xyz=opq
 ```
 
+#### `urlSearchParams.size`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+The total number of parameter entries.
+
 #### `urlSearchParams.sort()`
 
 <!-- YAML
diff --git a/lib/internal/url.js b/lib/internal/url.js
index 20d637057f6dea..366499e47789f5 100644
--- a/lib/internal/url.js
+++ b/lib/internal/url.js
@@ -268,6 +268,12 @@ class URLSearchParams {
     return `${this.constructor.name} {}`;
   }
 
+  get size() {
+    if (!isURLSearchParams(this))
+      throw new ERR_INVALID_THIS('URLSearchParams');
+    return this[searchParams].length / 2;
+  }
+
   append(name, value) {
     if (!isURLSearchParams(this))
       throw new ERR_INVALID_THIS('URLSearchParams');
@@ -511,6 +517,7 @@ ObjectDefineProperties(URLSearchParams.prototype, {
   getAll: kEnumerableProperty,
   has: kEnumerableProperty,
   set: kEnumerableProperty,
+  size: kEnumerableProperty,
   sort: kEnumerableProperty,
   entries: kEnumerableProperty,
   forEach: kEnumerableProperty,
diff --git a/test/parallel/test-whatwg-url-properties.js b/test/parallel/test-whatwg-url-properties.js
index 692847471178bb..69ce14a431a9b7 100644
--- a/test/parallel/test-whatwg-url-properties.js
+++ b/test/parallel/test-whatwg-url-properties.js
@@ -65,6 +65,14 @@ const { URL, URLSearchParams, format } = require('url');
   testMethod(URLSearchParams.prototype, name, methodName);
 });
 
+{
+  const params = new URLSearchParams();
+  params.append('a', 'b');
+  params.append('a', 'c');
+  params.append('b', 'c');
+  assert.strictEqual(params.size, 3);
+}
+
 function stringifyName(name) {
   if (typeof name === 'symbol') {
     const { description } = name;