doc: fix more links

Fix broken links found by the checker, and exclude test/fixtures as it contains invalid links. Also exclude doc/changelogs because they're huge files which take very long to parse, and (IIRC) are auto-generated anyway. (Oh and also a nit at the README next to my link) PR-URL: #32586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Apr 11, 2020 · 1dee8c1 · 1dee8c1
1 parent d513b55
commit 1dee8c1
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 9 deletions.
diff --git a/GOVERNANCE.md b/GOVERNANCE.md
@@ -7,7 +7,7 @@
 * [Technical Steering Committee](#technical-steering-committee)
   * [TSC Meetings](#tsc-meetings)
 * [Collaborator Nominations](#collaborator-nominations)
-  * [Onboarding](#./onboarding)
+  * [Onboarding](#onboarding)
 * [Consensus Seeking Process](#consensus-seeking-process)
 
 <!-- /TOC -->

diff --git a/README.md b/README.md
@@ -349,7 +349,7 @@ For information about the governance of the Node.js project, see
 **Matteo Collina** &lt;[email protected]&gt; (he/him)
 * [mhdawson](https://github.com/mhdawson) -
 **Michael Dawson** &lt;[email protected]&gt; (he/him)
-* [mildsunrise](https://github.com/mildsunrise)
+* [mildsunrise](https://github.com/mildsunrise) -
 **Alba Mendez** &lt;[email protected]&gt; (she/her)
 * [misterdjules](https://github.com/misterdjules) -
 **Julien Gilli** &lt;[email protected]&gt;

diff --git a/doc/guides/collaborator-guide.md b/doc/guides/collaborator-guide.md
@@ -752,13 +752,13 @@ If you cannot find who to cc for a file, `git shortlog -n -s <file>` may help.
 
 ["Merge Pull Request"]: https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-on-github
 [Deprecation]: https://en.wikipedia.org/wiki/Deprecation
-[Stability Index]: doc/api/documentation.md#stability-index
+[Stability Index]: ../api/documentation.md#stability-index
 [TSC]: https://github.com/nodejs/TSC
-[`--pending-deprecation`]: doc/api/cli.md#--pending-deprecation
-[`--throw-deprecation`]: doc/api/cli.md#--throw-deprecation
+[`--pending-deprecation`]: ../api/cli.md#--pending-deprecation
+[`--throw-deprecation`]: ../api/cli.md#--throw-deprecation
 [`node-core-utils`]: https://github.com/nodejs/node-core-utils
-[backporting guide]: doc/guides/backporting-to-release-lines.md
-[commit message guidelines]: ./doc/guides/contributing/pull-requests.md#commit-message-guidelines
+[backporting guide]: backporting-to-release-lines.md
+[commit message guidelines]: contributing/pull-requests.md#commit-message-guidelines
 [commit-example]: https://github.com/nodejs/node/commit/b636ba8186
 [git-node]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md
 [git-node-metadata]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-metadata

diff --git a/doc/guides/doc-style-guide.md b/doc/guides/doc-style-guide.md
@@ -68,4 +68,4 @@ See also API documentation structure overview in [doctools README][].
 [Javascript type]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Grammar_and_types#Data_structures_and_types
 [serial commas]: https://en.wikipedia.org/wiki/Serial_comma
 [plugin]: https://editorconfig.org/#download
-[doctools README]: ../tools/doc/README.md
+[doctools README]: ../../tools/doc/README.md
diff --git a/onboarding.md b/onboarding.md
@@ -110,7 +110,7 @@ onboarding session.
     organization (not just Collaborators on Node.js core) have access. Its
     contents should not be shared externally.
   * You can find the full moderation policy
-    [here](https://github.com/nodejs/TSC/blob/master/Moderation-Policy.md).
+    [here](https://github.com/nodejs/admin/blob/master/Moderation-Policy.md).
 
 ## Reviewing PRs
 

diff --git a/tools/doc/checkLinks.js b/tools/doc/checkLinks.js
@@ -27,6 +27,8 @@ function findMarkdownFilesRecursively(dirPath) {
     if (
       entry.isDirectory() &&
       entry.name !== 'api' &&
+      entry.name !== 'fixtures' &&
+      entry.name !== 'changelogs' &&
       entry.name !== 'deps' &&
       entry.name !== 'node_modules'
     ) {