From 1bb034654724226595605ee29ddc9b31d837eb3b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 19 Aug 2018 09:15:04 -0700 Subject: [PATCH] test: fix flaky http timeout test There is no guarantee that a timeout won't be delayed considerably due to unrelated activity on the host. Instead of checking that the timeout happens within a certain tolerance, simply check that it did not happen too soon. Fixes: https://github.com/nodejs/node/issues/22041 PR-URL: https://github.com/nodejs/node/pull/22403 Reviewed-By: Ruben Bridgewater Reviewed-By: Refael Ackermann Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca --- .../sequential/test-http-client-timeout-option-with-agent.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/sequential/test-http-client-timeout-option-with-agent.js b/test/sequential/test-http-client-timeout-option-with-agent.js index a7f750a42e557b..63f683975dc9d0 100644 --- a/test/sequential/test-http-client-timeout-option-with-agent.js +++ b/test/sequential/test-http-client-timeout-option-with-agent.js @@ -42,8 +42,9 @@ function doRequest() { timeout_events += 1; const duration = Date.now() - start; // The timeout event cannot be precisely timed. It will delay - // some number of milliseconds, so test it in second units. - assert.strictEqual(duration / 1000 | 0, HTTP_CLIENT_TIMEOUT / 1000); + // some number of milliseconds. + assert.ok(duration >= HTTP_CLIENT_TIMEOUT, + `${duration} < ${HTTP_CLIENT_TIMEOUT}`); })); req.end();