From 1a324f2b8551a431e0d6e9597f073ae2694cc484 Mon Sep 17 00:00:00 2001 From: David Bradford Date: Thu, 1 Dec 2016 10:02:09 -0600 Subject: [PATCH] test: refactor test-vm-static-this.js Remove console statements and prefer strictEqual() over equal() in assertions. PR-URL: https://github.com/nodejs/node/pull/9887 Reviewed-By: Colin Ihrig --- test/parallel/test-vm-static-this.js | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/test/parallel/test-vm-static-this.js b/test/parallel/test-vm-static-this.js index a3cf2d820c3423..c4f10c183b6ef2 100644 --- a/test/parallel/test-vm-static-this.js +++ b/test/parallel/test-vm-static-this.js @@ -5,21 +5,21 @@ var vm = require('vm'); common.globalCheck = false; -console.error('run a string'); +// Run a string var result = vm.runInThisContext('\'passed\';'); -assert.equal('passed', result); +assert.strictEqual('passed', result); -console.error('thrown error'); +// thrown error assert.throws(function() { vm.runInThisContext('throw new Error(\'test\');'); }, /test/); global.hello = 5; vm.runInThisContext('hello = 2'); -assert.equal(2, global.hello); +assert.strictEqual(2, global.hello); -console.error('pass values'); +// pass values var code = 'foo = 1;' + 'bar = 2;' + 'if (typeof baz !== \'undefined\') throw new Error(\'test fail\');'; @@ -28,11 +28,11 @@ global.obj = { foo: 0, baz: 3 }; /* eslint-disable no-unused-vars */ var baz = vm.runInThisContext(code); /* eslint-enable no-unused-vars */ -assert.equal(0, global.obj.foo); -assert.equal(2, global.bar); -assert.equal(1, global.foo); +assert.strictEqual(0, global.obj.foo); +assert.strictEqual(2, global.bar); +assert.strictEqual(1, global.foo); -console.error('call a function'); +// call a function global.f = function() { global.foo = 100; }; vm.runInThisContext('f()'); -assert.equal(100, global.foo); +assert.strictEqual(100, global.foo);