Skip to content

Commit

Permalink
doc: improve COLLABORATOR_GUIDE
Browse files Browse the repository at this point in the history
PR-URL: #23977
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
  • Loading branch information
jagannathBhat authored and MylesBorins committed Nov 27, 2018
1 parent a9dcf6f commit 17c2ddd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ This should be done where a pull request:

Assign the `tsc-review` label or @-mention the
`@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][].
Do not use the GitHub UI on the right hand side to assign to
Do not use the GitHub UI on the right-hand side to assign to
`@nodejs/tsc` or request a review from `@nodejs/tsc`.

The TSC should serve as the final arbiter where required.
Expand Down Expand Up @@ -528,7 +528,7 @@ The TSC should serve as the final arbiter where required.
you are unsure exactly how to format the commit messages, use the commit log
as a reference. See [this commit][commit-example] as an example.

For PRs from first time contributors, be [welcoming](#welcoming-first-time-contributors).
For PRs from first-time contributors, be [welcoming](#welcoming-first-time-contributors).
Also, verify that their git settings are to their liking.

All commits should be self-contained, meaning every commit should pass all
Expand Down

0 comments on commit 17c2ddd

Please sign in to comment.