worker: remove file extension check

Fixes: #39124 PR-URL: #39788 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · Sep 6, 2021 · 16271d2 · 16271d2
1 parent 9270684
commit 16271d2
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 26 deletions.
diff --git a/doc/api/errors.md b/doc/api/errors.md
@@ -2502,12 +2502,6 @@ nor a relative path starting with `./` or `../`.
 
 All attempts at serializing an uncaught exception from a worker thread failed.
 
-<a id="ERR_WORKER_UNSUPPORTED_EXTENSION"></a>
-### `ERR_WORKER_UNSUPPORTED_EXTENSION`
-
-The pathname used for the main script of a worker has an
-unknown file extension.
-
 <a id="ERR_WORKER_UNSUPPORTED_OPERATION"></a>
 ### `ERR_WORKER_UNSUPPORTED_OPERATION`
 

diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -1617,9 +1617,6 @@ E('ERR_WORKER_PATH', (filename) =>
   TypeError);
 E('ERR_WORKER_UNSERIALIZABLE_ERROR',
   'Serializing an uncaught exception failed', Error);
-E('ERR_WORKER_UNSUPPORTED_EXTENSION',
-  'The worker script extension must be ".js", ".mjs", or ".cjs". Received "%s"',
-  TypeError);
 E('ERR_WORKER_UNSUPPORTED_OPERATION',
   '%s is not supported in workers', TypeError);
 E('ERR_ZLIB_INITIALIZATION_FAILED', 'Initialization failed', Error);
diff --git a/lib/internal/worker.js b/lib/internal/worker.js
@@ -35,7 +35,6 @@ const {
   ERR_WORKER_NOT_RUNNING,
   ERR_WORKER_PATH,
   ERR_WORKER_UNSERIALIZABLE_ERROR,
-  ERR_WORKER_UNSUPPORTED_EXTENSION,
   ERR_WORKER_INVALID_EXEC_ARGV,
   ERR_INVALID_ARG_TYPE,
   ERR_INVALID_ARG_VALUE,
@@ -167,11 +166,6 @@ class Worker extends EventEmitter {
       } else {
         throw new ERR_WORKER_PATH(filename);
       }
-
-      const ext = path.extname(filename);
-      if (ext !== '.js' && ext !== '.mjs' && ext !== '.cjs') {
-        throw new ERR_WORKER_UNSUPPORTED_EXTENSION(ext);
-      }
     }
 
     let env;

diff --git a/test/parallel/test-worker-unsupported-path.js b/test/parallel/test-worker-unsupported-path.js
@@ -5,17 +5,6 @@ const path = require('path');
 const assert = require('assert');
 const { Worker } = require('worker_threads');
 
-{
-  const expectedErr = {
-    code: 'ERR_WORKER_UNSUPPORTED_EXTENSION',
-    name: 'TypeError'
-  };
-  assert.throws(() => { new Worker('/b'); }, expectedErr);
-  assert.throws(() => { new Worker('/c.wasm'); }, expectedErr);
-  assert.throws(() => { new Worker('/d.txt'); }, expectedErr);
-  assert.throws(() => { new Worker(new URL('file:///C:/e.wasm')); }, expectedErr);
-}
-
 {
   const expectedErr = {
     code: 'ERR_WORKER_PATH',