perf_hooks: remove useless calls in Histogram

Coverity reported some calls that had no effect, remove them Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41579 Reviewed-By: Yash Ladha <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
nodejs · Feb 7, 2022 · 14cb9ea · 14cb9ea
1 parent cfaa1e2
commit 14cb9ea
Showing 1 changed file with 16 additions and 16 deletions.
diff --git a/src/histogram.cc b/src/histogram.cc
@@ -159,10 +159,10 @@ void HistogramBase::GetPercentiles(const FunctionCallbackInfo<Value>& args) {
   CHECK(args[0]->IsMap());
   Local<Map> map = args[0].As<Map>();
   (*histogram)->Percentiles([map, env](double key, int64_t value) {
-    map->Set(
-        env->context(),
-        Number::New(env->isolate(), key),
-        Number::New(env->isolate(), static_cast<double>(value))).IsEmpty();
+    USE(map->Set(
+          env->context(),
+          Number::New(env->isolate(), key),
+          Number::New(env->isolate(), static_cast<double>(value))));
   });
 }
 
@@ -174,10 +174,10 @@ void HistogramBase::GetPercentilesBigInt(
   CHECK(args[0]->IsMap());
   Local<Map> map = args[0].As<Map>();
   (*histogram)->Percentiles([map, env](double key, int64_t value) {
-    map->Set(
-        env->context(),
-        Number::New(env->isolate(), key),
-        BigInt::New(env->isolate(), value)).IsEmpty();
+    USE(map->Set(
+          env->context(),
+          Number::New(env->isolate(), key),
+          BigInt::New(env->isolate(), value)));
   });
 }
 
@@ -589,10 +589,10 @@ void IntervalHistogram::GetPercentiles(
   CHECK(args[0]->IsMap());
   Local<Map> map = args[0].As<Map>();
   (*histogram)->Percentiles([map, env](double key, int64_t value) {
-    map->Set(
-        env->context(),
-        Number::New(env->isolate(), key),
-        Number::New(env->isolate(), static_cast<double>(value))).IsEmpty();
+    USE(map->Set(
+          env->context(),
+          Number::New(env->isolate(), key),
+          Number::New(env->isolate(), static_cast<double>(value))));
   });
 }
 
@@ -604,10 +604,10 @@ void IntervalHistogram::GetPercentilesBigInt(
   CHECK(args[0]->IsMap());
   Local<Map> map = args[0].As<Map>();
   (*histogram)->Percentiles([map, env](double key, int64_t value) {
-    map->Set(
-        env->context(),
-        Number::New(env->isolate(), key),
-        BigInt::New(env->isolate(), value)).IsEmpty();
+    USE(map->Set(
+          env->context(),
+          Number::New(env->isolate(), key),
+          BigInt::New(env->isolate(), value)));
   });
 }