tools: remove no-goma arg from make-v8 script

V8 recently removed its support and passing it makes canary builds fail. It should be safe to remove it now as the default behavior is to look for goma in the PATH, and CI hosts shouldn't have goma installed. Refs: v8/v8@6c5a6c0 PR-URL: #53336 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Jun 7, 2024 · 0ecb770 · 0ecb770
1 parent fef067f
commit 0ecb770
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/tools/make-v8.sh b/tools/make-v8.sh
@@ -55,6 +55,6 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then
 else
   DEPOT_TOOLS_DIR="$(cd _depot_tools && pwd)"
   # shellcheck disable=SC2086
-  PATH="$DEPOT_TOOLS_DIR":$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" --no-goma $V8_BUILD_OPTIONS
+  PATH="$DEPOT_TOOLS_DIR":$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" $V8_BUILD_OPTIONS
   PATH="$DEPOT_TOOLS_DIR":$PATH ninja -C "out.gn/$BUILD_ARCH_TYPE/" "${JOBS_ARG}" d8 cctest inspector-test
 fi