lib: fix a few minor issues flagged by lgtm

* Confusing (but correct) regex using `A-z` character range by accident * Add the status argument to afterShutdown PR-URL: #25873 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
nodejs · Feb 6, 2019 · 0b302e4 · 0b302e4
1 parent 353de0f
commit 0b302e4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -1518,7 +1518,8 @@ function streamOnPause() {
     this[kHandle].readStop();
 }
 
-function afterShutdown() {
+function afterShutdown(status) {
+  // Currently this status value is unused
   this.callback();
   const stream = this.handle[kOwner];
   if (stream)

diff --git a/tools/cpplint.py b/tools/cpplint.py
@@ -636,7 +636,7 @@ def GetNonHeaderExtensions():
 
 _RIGHT_LEANING_POINTER_PATTERN = re.compile(r'[^=|(,\s><);&?:}]'
                                             r'(?<!(sizeof|return))'
-                                            r'\s\*[a-zA-z_][0-9a-zA-z_]*')
+                                            r'\s\*[a-zA-Z_][0-9a-zA-Z_]*')
 
 _regexp_compile_cache = {}