From 0a5ff4cb331fb3e7ff4c53922ee2e2cef6870fe7 Mon Sep 17 00:00:00 2001
From: Refael Ackermann <refack@gmail.com>
Date: Thu, 23 May 2019 18:57:12 -0400
Subject: [PATCH] deps: V8: template explicit instantiation for GCC-8
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fails to link for missing:
void JSObject::ApplyAttributesToDictionary<NumberDictionary>(...)

Backport-PR-URL: https://github.com/nodejs/node/pull/28005
PR-URL: https://github.com/nodejs/node/pull/27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
---
 common.gypi                       | 2 +-
 deps/v8/src/elements.cc           | 5 +++++
 deps/v8/src/objects/js-objects.cc | 5 +++++
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/common.gypi b/common.gypi
index e4af01543a1562..4ca7079c0cc2fd 100644
--- a/common.gypi
+++ b/common.gypi
@@ -38,7 +38,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.9',
+    'v8_embedder_string': '-node.10',
 
     ##### V8 defaults for Node.js #####
 
diff --git a/deps/v8/src/elements.cc b/deps/v8/src/elements.cc
index b523cd7dde421a..5262cb7a60d272 100644
--- a/deps/v8/src/elements.cc
+++ b/deps/v8/src/elements.cc
@@ -62,6 +62,11 @@
 namespace v8 {
 namespace internal {
 
+// Explicit instantiation declarations.
+extern template void JSObject::ApplyAttributesToDictionary(
+    Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,
+    const PropertyAttributes attributes);
+
 
 namespace {
 
diff --git a/deps/v8/src/objects/js-objects.cc b/deps/v8/src/objects/js-objects.cc
index 841eec0edf4230..5191f237f6712b 100644
--- a/deps/v8/src/objects/js-objects.cc
+++ b/deps/v8/src/objects/js-objects.cc
@@ -5836,5 +5836,10 @@ Handle<String> JSMessageObject::GetSourceLine() const {
   return isolate->factory()->NewSubString(src, info.line_start, info.line_end);
 }
 
+// Explicit instantiation definitions.
+template void JSObject::ApplyAttributesToDictionary(
+    Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,
+    const PropertyAttributes attributes);
+
 }  // namespace internal
 }  // namespace v8