From 09aec436cb8b69bb98cc3eea6dc6f5d0b15eb646 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 29 May 2018 19:59:28 -0700 Subject: [PATCH] doc: remove vestigial onboarding section The onboarding-extras doc includes a section with a single bullet point instructing the new Collaborator to write good pull request descriptions. This material is likely superfluous and is in the wrong document if it is not. (It more properly belongs in pull-requests.md as it is information that is not specific to new Collaborators.) I am not putting it in pullrequests.md because that document is already plenty long and detailed, and includes advice on writing good commit messages, which tend to become the pull request descriptions anyway. PR-URL: https://github.com/nodejs/node/pull/21028 Reviewed-By: Jon Moss Reviewed-By: Vse Mozhet Byt Reviewed-By: Tiancheng "Timothy" Gu Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Trivikram Kamat --- doc/onboarding-extras.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md index 62a7f7bb6b2837..74317c7e2bc962 100644 --- a/doc/onboarding-extras.md +++ b/doc/onboarding-extras.md @@ -93,7 +93,3 @@ to update from nodejs/node: * `git checkout master` * `git remote update -p` OR `git fetch --all` * `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`) - -## Best practices - -* When making PRs, spend time writing a thorough description.