src,buffer: evaluate THROW_AND_RETURN_IF_OOB() expression only once

There's no need to evaluate the expression passed into the macro more than once. Fixes: #41935 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #41945 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Feb 21, 2022 · 047d4de · 047d4de
1 parent 0cc1a27
commit 047d4de
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/node_buffer.cc b/src/node_buffer.cc
@@ -41,8 +41,9 @@
 
 #define THROW_AND_RETURN_IF_OOB(r)                                          \
   do {                                                                      \
-    if ((r).IsNothing()) return;                                            \
-    if (!(r).FromJust())                                                    \
+    Maybe<bool> m = (r);                                                    \
+    if (m.IsNothing()) return;                                              \
+    if (!m.FromJust())                                                      \
       return node::THROW_ERR_OUT_OF_RANGE(env, "Index out of range");       \
   } while (0)                                                               \