src: make sure Utf8Value always zero-terminates

Make sure dereferencing a `Utf8Value` instance always returns a zero-terminated string, even if the conversion to string failed. The corresponding bugfix in the master branch happened in 44a4032 (#6357). Ref: #6357 PR-URL: #7101 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
nodejs · Jun 24, 2016 · 037291e · 037291e
1 parent a31153c
commit 037291e
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/util.cc b/src/util.cc
@@ -5,6 +5,10 @@ namespace node {
 
 Utf8Value::Utf8Value(v8::Isolate* isolate, v8::Local<v8::Value> value)
     : length_(0), str_(str_st_) {
+  // Make sure result is always zero-terminated, even if conversion to string
+  // fails.
+  str_st_[0] = '\0';
+
   if (value.IsEmpty())
     return;