From 035a24e619a19e6911bc7887a128bf03b301964e Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Wed, 15 Nov 2017 23:53:50 +0800 Subject: [PATCH] build: enforce order of dependency when building addons PR-URL: https://github.com/nodejs/node/pull/17048 Fixes: https://github.com/nodejs/node/issues/17043 Reviewed-By: James M Snell Reviewed-By: Anna Henningsen --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index fce5d7146ad3df..7e4b33d571ee79 100644 --- a/Makefile +++ b/Makefile @@ -314,7 +314,7 @@ test/addons/.buildstamp: config.gypi \ # .buildstamp is out of date and need a rebuild. # Just goes to show that recursive make really is harmful... # TODO(bnoordhuis) Force rebuild after gyp update. -build-addons: $(NODE_EXE) test/addons/.buildstamp +build-addons: | $(NODE_EXE) test/addons/.buildstamp ADDONS_NAPI_BINDING_GYPS := \ $(filter-out test/addons-napi/??_*/binding.gyp, \ @@ -353,7 +353,7 @@ test/addons-napi/.buildstamp: config.gypi \ # .buildstamp is out of date and need a rebuild. # Just goes to show that recursive make really is harmful... # TODO(bnoordhuis) Force rebuild after gyp or node-gyp update. -build-addons-napi: $(NODE_EXE) test/addons-napi/.buildstamp +build-addons-napi: | $(NODE_EXE) test/addons-napi/.buildstamp clear-stalled: # Clean up any leftover processes but don't error if found.