util: support Combining Diacritical Marks for Symbols

This adds support for the "Combining Diacritical Marks for Symbols" unicode group to calculate a zero length width even if Node.js is built without ICU. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #33650 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Jul 12, 2020 · 02ae3f5 · 02ae3f5
1 parent 04ceeaf
commit 02ae3f5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 15 deletions.
diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -2050,6 +2050,8 @@ if (internalBinding('config').hasIntl) {
       (code > 0x7F && code <= 0x9F) || // C1 control codes
       (code >= 0x300 && code <= 0x36F) || // Combining Diacritical Marks
       (code >= 0x200B && code <= 0x200F) || // Modifying Invisible Characters
+      // Combining Diacritical Marks for Symbols
+      (code >= 0x20D0 && code <= 0x20FF) ||
       (code >= 0xFE00 && code <= 0xFE0F) || // Variation Selectors
       (code >= 0xFE20 && code <= 0xFE2F) || // Combining Half Marks
       (code >= 0xE0100 && code <= 0xE01EF); // Variation Selectors

diff --git a/test/parallel/test-readline-position.js b/test/parallel/test-readline-position.js
@@ -1,7 +1,6 @@
 // Flags: --expose-internals
 'use strict';
 const common = require('../common');
-const { internalBinding } = require('internal/test/binding');
 const { PassThrough } = require('stream');
 const readline = require('readline');
 const assert = require('assert');
@@ -21,22 +20,14 @@ common.skipIfDumbTerminal();
   const tests = [
     [1, 'a'],
     [2, 'ab'],
-    [2, '丁']
+    [2, '丁'],
+    [0, '\u0301'],   // COMBINING ACUTE ACCENT
+    [1, 'a\u0301'],  // á
+    [0, '\u20DD'],   // COMBINING ENCLOSING CIRCLE
+    [2, 'a\u20DDb'], // a⃝b
+    [0, '\u200E'],   // LEFT-TO-RIGHT MARK
   ];
 
-  // The non-ICU JS implementation of character width calculation is only aware
-  // of the wide/narrow distinction. Only test these more advanced cases when
-  // ICU is available.
-  if (internalBinding('config').hasIntl) {
-    tests.push(
-      [0, '\u0301'],   // COMBINING ACUTE ACCENT
-      [1, 'a\u0301'],  // á
-      [0, '\u20DD'],   // COMBINING ENCLOSING CIRCLE
-      [2, 'a\u20DDb'], // a⃝b
-      [0, '\u200E']    // LEFT-TO-RIGHT MARK
-    );
-  }
-
   for (const [cursor, string] of tests) {
     rl.write(string);
     assert.strictEqual(rl.getCursorPos().cols, cursor);