Revert "src: ignore GCC -Wcast-function-type for v8.h"

This reverts commit f21cf45 as this has now been included in the V8 version being used. PR-URL: #35758 Refs: v8/v8@f08cbfd Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Nov 3, 2020 · 01d7c46 · 01d7c46
1 parent 6211ffd
commit 01d7c46
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 14 deletions.
diff --git a/src/string_bytes.h b/src/string_bytes.h
@@ -26,14 +26,7 @@
 
 // Decodes a v8::Local<v8::String> or Buffer to a raw char*
 
-#if (__GNUC__ >= 8) && !defined(__clang__)
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wcast-function-type"
-#endif
 #include "v8.h"
-#if (__GNUC__ >= 8) && !defined(__clang__)
-#pragma GCC diagnostic pop
-#endif
 #include "env-inl.h"
 
 #include <string>

diff --git a/test/cctest/test_aliased_buffer.cc b/test/cctest/test_aliased_buffer.cc
@@ -1,11 +1,4 @@
-#if (__GNUC__ >= 8) && !defined(__clang__)
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wcast-function-type"
-#endif
 #include "v8.h"
-#if (__GNUC__ >= 8) && !defined(__clang__)
-#pragma GCC diagnostic pop
-#endif
 #include "aliased_buffer.h"
 #include "node_test_fixture.h"